-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(portal): detect changes for portal hostview while before attaching. #4370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d186ff to
6f6cc27
Compare
f085a7f to
76aa323
Compare
|
@jelbourn ready for you to take a look |
| let componentFactory = this._componentFactoryResolver.resolveComponentFactory(portal.component); | ||
| let componentRef: ComponentRef<T>; | ||
| let componentRef = componentFactory.create(portal.injector || this._defaultInjector); | ||
| componentRef.hostView.detectChanges(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to create a unit test that enforces this behavior?
f7b6f53 to
bdb9e7f
Compare
|
Should be ready for another look. I updated cc:@mmalerba as this is modifying the newly created |
jelbourn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the portal stuff
@mmalerba should take a look for the datepicker
|
LGTM for datepicker |
|
@jelbourn @mmalerba @josephperrott the CD changes made here are causing several regressions with the datepicker in popup view
ref #5065 |
…attaching. (angular#4370)" This reverts commit 28d2ddd.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
#4318